Fix default model bug (#161)#162
Closed
gauravch-code wants to merge 1 commit intoBoise-State-Development:developfrom
Closed
Fix default model bug (#161)#162gauravch-code wants to merge 1 commit intoBoise-State-Development:developfrom
gauravch-code wants to merge 1 commit intoBoise-State-Development:developfrom
Conversation
gauravch-code
force-pushed
the
feature/fix-default-model-161
branch
from
6a79b07 to
9c22768
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the race condition in the frontend model dropdown and ensures the backend properly inherits the user's saved preference.
Changes Made:
Updated currentDefaultModelId in chat-preferences-settings.page.ts to wait for both user settings and available models before emitting a value.
Updated model.service.ts to consult the user's personal default from the settings API.
Updated routes.py in the chat API to query the saved defaultModelId from DynamoDB if model_id is None during agent creation